Skip to content

relicensing: Rewrite allocator, configuration table, and image unload PRs #1523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 22, 2025

Conversation

nicholasbishop
Copy link
Member

See #1521. This rewrites code from medhefgo that we do not have relicensing approval for.

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

The allocator code has already changed a fair amount since that PR landed, so
only docstrings needed to be rewritten.

This covers these commits:
9dbdfe9
e6803d7
…) signature"

The signature fix itself is trivial, just adding a `&`. The test changes had
already been partially rewritten during the freestanding table function
refactor. Now alter constants and variable names, remove a use of `as`, and free
the memory at the end.

The PR originally included a cleanup commit ("uefi-test-runner: Fix buffer
alignment on ia32") that ended up being cherry-picked and merged in a separate
PR: rust-osdev#844. Rewrite that fix here as
well.

This covers these commits:
d7697c3
9609873
Copy link
Member

@phip1611 phip1611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking care of this!

@phip1611 phip1611 added this pull request to the merge queue Jan 22, 2025
Merged via the queue into rust-osdev:main with commit 5fa380f Jan 22, 2025
15 checks passed
@nicholasbishop nicholasbishop deleted the bishop-rewrite-jj branch January 22, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants